Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display senderName when provided #1760

Closed
seanes opened this issue Jan 30, 2025 · 1 comment
Closed

Display senderName when provided #1760

seanes opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
dev developer task

Comments

@seanes
Copy link
Contributor

seanes commented Jan 30, 2025

Display dialog.content.senderName, cf. https://docs.altinn.studio/dialogporten/reference/entities/dialog/#V1EndUserDialogsQueriesGet_Dialog_content_senderName, (optional) is not displayed as sender today. Rather we are using dialog.org (i.e. dialog owner) as sender, through mapping org code to name and logo here: https://altinncdn.no/orgs/altinn-orgs.json

dialog.content.senderName is sender / creator of the dialog and should when provided be displayed instead of owner, e.g. Politiet Avd. Oslo can be senderName, while the owner is Politiet or Sivilforsvaret with service owner DSB.

Implementation:

  1. Display senderName if provided.
  2. Display name of dialog owner (service owner) if senderName isn't provided.

Out of scope (discussion for next iteration of displaying sender name):
Should we display the owner as well and use the service owner's logo? It might be confusing that we filter by a given service owner, while the dialogs have a different sender name as display label?

@seanes seanes added the dev developer task label Jan 30, 2025
@mbacherycz mbacherycz self-assigned this Feb 5, 2025
@mbacherycz mbacherycz moved this from Ready to Doing in Dialogporten / Arbeidsflate Feb 5, 2025
@mbacherycz mbacherycz moved this from Doing to Code Review og PR in Dialogporten / Arbeidsflate Feb 6, 2025
@mbacherycz mbacherycz moved this from Code Review og PR to Testing in Dialogporten / Arbeidsflate Feb 7, 2025
@LeifHelstad
Copy link
Contributor

Test

Kritere 2 - senderName er ikke med

Image

Image

Kriterie 1 - senderName er valgt

Image

Image

=> Test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer task
Projects
Status: Done
Development

No branches or pull requests

3 participants