-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correspondence client #897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir respective feature namespace
src/Altinn.App.Core/Features/Maskinporten/Extensions/WebHostBuilderExtensions.cs
Dismissed
Show dismissed
Hide dismissed
martinothamar
approved these changes
Nov 21, 2024
src/Altinn.App.Core/Features/Correspondence/CorrespondenceClient.cs
Dismissed
Show dismissed
Hide dismissed
…espondence-client
src/Altinn.App.Core/Features/Correspondence/Builder/CorrespondenceAttachmentBuilder.cs
Dismissed
Show dismissed
Hide dismissed
src/Altinn.App.Core/Features/Correspondence/Builder/CorrespondenceContentBuilder.cs
Dismissed
Show dismissed
Hide dismissed
src/Altinn.App.Core/Features/Correspondence/Builder/CorrespondenceRequestBuilder.cs
Dismissed
Show dismissed
Hide dismissed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has perhaps become a bit large and unruly, but there were many interleaved concepts involved in this feature, which turned out to be difficult to separate.
Maskinporten
The MaskinportenClient has been extended to allow for a second (internal use) instance, and the possiblity of exchanging Maskinporten tokens for Altinn tokens. Some updates have been made to the data models which may be considered breaking changes.
I have also renamed
HttpClientBuilderExtensions.UseMaskinportenAuthorization
, but forwarded the legacy method to the new one. It's not clear to me if this is necessary or not -- it's extremely unlikely that anyone has started using this product yet.Correspondence
The CorrespondenceClient and all associated logic/models/functionality is brand new. The implementation of this ecosystem is the main bulk of the PR.
The naming conventions for all things Correspondence could use a second pair of eyes. Perhaps especially the CorrespondenceRequestBuilder pattern naming.
Telemetry
The Telemetry class has been extended with a partial class for Correspondence, and CorrespondenceClient implements
StartActivity
and request counting. This does not cover all objectives in #832, so more work is likely needed in this area.Misc
Certain data that has traditionally been "stringly typed" now has their own struct types:
AccessToken
,OrganisationNumber
andLanguageCode
. Implicit operators and JSON converters have been added where applicable for current use.Related Issue(s)
ICorrespondenceClient
#825ICorrespondenceClient
#826IMaskinportenClient
#849Verification
Documentation