Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DefaultTaskEvents in process engine into smaller interfaces and classes #471

Merged

Conversation

bjorntore
Copy link
Contributor

@bjorntore bjorntore commented Mar 1, 2024

Split DefaultTaskEvents in process engine into smaller interfaces and classes. Restructuring of process task handling in general.

Description

Most of the process task related functionality was implemented in one class. Splitting it up and laying the grounds for more advanced process tasks to come in the near future. Payment etc.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@bjorntore bjorntore requested review from ivarne, tjololo and RonnyB71 March 1, 2024 09:47
@bjorntore bjorntore self-assigned this Mar 1, 2024
@bjorntore bjorntore force-pushed the feat/refactor-process-engine-split-default-task-events branch 2 times, most recently from 6a14cf9 to d0dacb0 Compare March 1, 2024 11:55
@ivarne ivarne changed the base branch from v8 to main March 6, 2024 09:06
@bjorntore bjorntore force-pushed the feat/refactor-process-engine-split-default-task-events branch 3 times, most recently from 39e7175 to df559f6 Compare March 7, 2024 09:51
@bjorntore bjorntore requested a review from ivarne March 12, 2024 08:17
@bjorntore bjorntore force-pushed the feat/refactor-process-engine-split-default-task-events branch from df559f6 to 9c2729d Compare March 12, 2024 08:31
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicking

@bjorntore bjorntore force-pushed the feat/refactor-process-engine-split-default-task-events branch from 9c2729d to bdbc745 Compare March 19, 2024 07:59
… classes. Restructuring of process task handling in general.
@bjorntore bjorntore force-pushed the feat/refactor-process-engine-split-default-task-events branch from bdbc745 to 01e2fa3 Compare March 19, 2024 08:11
Copy link

@bjorntore bjorntore merged commit dfd5cff into main Mar 19, 2024
10 checks passed
@bjorntore bjorntore deleted the feat/refactor-process-engine-split-default-task-events branch March 19, 2024 08:26
@ivarne ivarne added the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Apr 2, 2024
@bjorntore bjorntore removed the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Apr 24, 2024
@bjorntore
Copy link
Contributor Author

Removing breaking-change label due to #613.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants