-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split DefaultTaskEvents in process engine into smaller interfaces and classes #471
Merged
bjorntore
merged 1 commit into
main
from
feat/refactor-process-engine-split-default-task-events
Mar 19, 2024
Merged
Split DefaultTaskEvents in process engine into smaller interfaces and classes #471
bjorntore
merged 1 commit into
main
from
feat/refactor-process-engine-split-default-task-events
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Altinn.App.Core/Internal/Process/ProcessTasks/Common/ProcessTaskInitializer.cs
Dismissed
Show dismissed
Hide dismissed
src/Altinn.App.Core/Internal/Process/ProcessTasks/Common/ProcessTaskFinalizer.cs
Fixed
Show fixed
Hide fixed
6a14cf9
to
d0dacb0
Compare
ivarne
reviewed
Mar 5, 2024
ivarne
reviewed
Mar 5, 2024
src/Altinn.App.Core/Internal/Process/ServiceTasks/Interfaces/IServiceTask.cs
Show resolved
Hide resolved
ivarne
reviewed
Mar 5, 2024
39e7175
to
df559f6
Compare
df559f6
to
9c2729d
Compare
tjololo
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nitpicking
src/Altinn.App.Core/Internal/Process/ProcessEventHandlingDelegator.cs
Outdated
Show resolved
Hide resolved
src/Altinn.App.Core/Internal/Process/ServiceTasks/EformidlingServiceTask.cs
Outdated
Show resolved
Hide resolved
src/Altinn.App.Core/Internal/Process/ServiceTasks/PdfServiceTask.cs
Outdated
Show resolved
Hide resolved
9c2729d
to
bdbc745
Compare
… classes. Restructuring of process task handling in general.
bdbc745
to
01e2fa3
Compare
|
5 tasks
3 tasks
Removing breaking-change label due to #613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split DefaultTaskEvents in process engine into smaller interfaces and classes. Restructuring of process task handling in general.
Description
Most of the process task related functionality was implemented in one class. Splitting it up and laying the grounds for more advanced process tasks to come in the near future. Payment etc.
Related Issue(s)
Verification
Documentation