Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/process tasks #353

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Feat/process tasks #353

merged 12 commits into from
Nov 30, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Nov 22, 2023 •
edited
Loading

Description

Adds a list ProcessTasks to AppProcessState. The list contains information about all currently available tasks, and their type.

It is used in the frontend to be able to render a specific taskId when we lift the state of the currently viewed task to the URL.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mikaelrss mikaelrss changed the base branch from main to v8 November 22, 2023 09:17
@mikaelrss mikaelrss force-pushed the feat/process-tasks branch 2 times, most recently from 7e01003 to 8bd3b25 Compare November 22, 2023 09:21
@mikaelrss mikaelrss marked this pull request as ready for review November 22, 2023 10:29
@mikaelrss mikaelrss requested a review from tjololo November 22, 2023 10:29
ivarne
ivarne reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@ivarne ivarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noen flere kommentarer.

src/Altinn.App.Core/Internal/Process/ProcessReader.cs Outdated Show resolved Hide resolved
test/Altinn.App.Api.Tests/Controllers/TestResources/ProcessControllerGetResponse.json Outdated Show resolved Hide resolved
test/Altinn.App.Api.Tests/Utils/PrincipalUtil.cs Outdated Show resolved Hide resolved
test/Altinn.App.Api.Tests/Controllers/ProcessControllerTests.cs Outdated Show resolved Hide resolved
@mikaelrss mikaelrss marked this pull request as draft November 24, 2023 06:16
@ivarne ivarne mentioned this pull request Nov 24, 2023
Merged
5 tasks
@tjololo tjololo marked this pull request as ready for review November 28, 2023 14:50
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 29, 2023
@tjololo tjololo requested a review from ivarne November 29, 2023 10:12
@ivarne
Copy link
Member

ivarne commented Nov 30, 2023

@tjololo There was a few conflicts with #367 because we solved problems differently.

Not sure which solution is best.

@tjololo
Copy link
Member

tjololo commented Nov 30, 2023

@tjololo There was a few conflicts with #367 because we solved problems differently.

Not sure which solution is best.

I think yours is more complete, setting usernames and other values to other than just hard coded values. Party Id should as far as I know always be set so forcing the tests to do the same or explicitly set null seems like the right thing.
I will merge the changes into this branch

@tjololo
Merge branch 'v8' into feat/process-tasks
f6b6e63 
# Conflicts:
#	test/Altinn.App.Api.Tests/Controllers/ActionsControllerTests.cs
#	test/Altinn.App.Api.Tests/Utils/PrincipalUtil.cs
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@tjololo tjololo merged commit a088662 into v8 Nov 30, 2023
10 checks passed
@tjololo tjololo deleted the feat/process-tasks branch November 30, 2023 09:00
@tjololo tjololo linked an issue Dec 1, 2023 that may be closed by this pull request
Extend /process with info about available tasks and their types #351
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarne ivarne ivarne approved these changes

@tjololo tjololo Awaiting requested review from tjololo

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend /process with info about available tasks and their types
3 participants
@mikaelrss @ivarne @tjololo