-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 feature/304 support custom button #346
Conversation
# Conflicts: # src/Altinn.App.Api/Controllers/ProcessController.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕹️
Fix comments from review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tror muligens det er en del filer som mangler [JsonPropertyName("")]
src/Altinn.App.Core/Infrastructure/Clients/Authorization/AuthorizationClient.cs
Outdated
Show resolved
Hide resolved
src/Altinn.App.Core/Infrastructure/Clients/Storage/ProcessClient.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
Remove IUserActionService and rename UserActionFactory to UserActionService Add JsonPropertyName to classes returned through the ActionsController
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the code smell/warning, and I think this code is ready to run and find bugs runtime instead.
test/Altinn.App.Core.Tests/Features/Action/UserActionServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Altinn.App.Core.Tests/Features/Action/UserActionServiceTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! |
🕹️ |
Description
Introduce actions endpoint for use by custom buttons
Related Issue(s)
Verification
Documentation