Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 feature/304 support custom button #346

Merged
merged 24 commits into from
Nov 27, 2023
Merged

V8 feature/304 support custom button #346

merged 24 commits into from
Nov 27, 2023

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Nov 20, 2023 •
edited
Loading

Description

Introduce actions endpoint for use by custom buttons

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@tjololo tjololo marked this pull request as ready for review November 22, 2023 08:59
@tjololo tjololo linked an issue Nov 22, 2023 that may be closed by this pull request
Support for custom button for executing app specific logic in a task #304
Closed
4 tasks
RonnyB71
RonnyB71 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@RonnyB71 RonnyB71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕹️

@ivarne ivarne self-requested a review November 23, 2023 22:02
@tjololo tjololo mentioned this pull request Nov 24, 2023
Closed
5 tasks
ivarne
ivarne reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@ivarne ivarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror muligens det er en del filer som mangler [JsonPropertyName("")]

@tjololo @ivarne
Apply first round of suggestions from code review
a154044 
Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
@tjololo
Apply suggestion from code review
1f5a64c 
Remove IUserActionService and rename UserActionFactory to UserActionService
Add JsonPropertyName to classes returned through the ActionsController
@tjololo
Remove ValidationGroup from IUserAction
6b7533f
ivarne
ivarne approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@ivarne ivarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the code smell/warning, and I think this code is ready to run and find bugs runtime instead.

tjololo and others added 2 commits November 24, 2023 14:44
@tjololo @ivarne
Apply suggestions from code review
6906f7c 
Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
@tjololo
Remove the need for NullUserAction
3901bec
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@ivarne
Copy link
Member

ivarne commented Nov 24, 2023

🕹️

@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 27, 2023
@tjololo tjololo merged commit 81296a3 into v8 Nov 27, 2023
@tjololo tjololo deleted the v8-feature/304-support-custom-button branch November 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarne ivarne ivarne approved these changes

@RonnyB71 RonnyB71 RonnyB71 approved these changes

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for custom button for executing app specific logic in a task
3 participants
@tjololo @ivarne @RonnyB71