Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header with parameters used when fetching options #292

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Add header with parameters used when fetching options #292

merged 2 commits into from
Aug 22, 2023

Conversation

RonnyB71
Copy link
Member

Description

This feature adds the parameters used when getting options to the response as a http header named Altinn-DownstreamParameters, and can be used for documenting the parameters used when getting a list of options.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

tjololo
tjololo approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@RonnyB71 RonnyB71 merged commit 3d35d03 into main Aug 22, 2023
@RonnyB71 RonnyB71 deleted the feature/return-options-parameters-used branch August 22, 2023 06:34
@RonnyB71 RonnyB71 added the feature Label Pull requests with new features. Used when generation releasenotes label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonnyB71 @tjololo