Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where datamodel field was removed when RepeatingGroup components' hidden expression differed #1073

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bug where datamodel field was removed when RepeatingGroup components' hidden expression differed #1073

wants to merge 2 commits into from

Conversation

martinothamar
Copy link
Contributor

Description

An else branch was missing in the RepeatingGroup case where 1 group is saying hidden = true and another is saying hidden = false

Related Issue(s)

  • N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar martinothamar added kind/bug Something isn't working bugfix Label Pull requests with bugfix. Used when generation releasenotes labels Jan 30, 2025
@martinothamar martinothamar self-assigned this Jan 30, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinothamar martinothamar

Labels
bugfix Label Pull requests with bugfix. Used when generation releasenotes kind/bug Something isn't working
Projects
Team Apps
Status: 🔎 Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinothamar