Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting the requested URL from a codelist for documentation #256

Closed
2 tasks
RonnyB71 opened this issue Jun 13, 2023 · 2 comments · Fixed by Altinn/app-frontend-react#1562
Closed
2 tasks
Assignees
Labels
kind/user-story Used for issues that describes functionality for our users. org/ssb Issues relevant for Statistisk sentralbyrå.

Comments

@RonnyB71
Copy link
Member

RonnyB71 commented Jun 13, 2023

Description

In order to document the source of a used codelist we need to expose the requested url to the application so we can store and document what the url was when it was used.

Additional Information

Clarifying the usage - it's not required with the url it self, but the parameters used when getting the codelist. The url might often not be generated due to caching. But the parameters will always be passed and can be returned for documentation purposes.

Solution

When backend responds with the options, the metadata/parameters used against the underlying api should be included in the response as a urlencoded header -> X-Altinn-DownstreamParameters

Frontend writes these metadata from the header to a configured field. Add the posibility to configure the datamodel binding to where in the datamodel the values should be stored.

Should be reimplemented with Tanstack Query ref. Altinn/app-frontend-react#1294

Acceptance Criterias

  • The parameters that was used should be exposed in the options api allowing it the be read by application developers
  • All places where options are used should have the option to configure where the parameteres should be stored.
@RonnyB71 RonnyB71 added kind/user-story Used for issues that describes functionality for our users. org/ssb Issues relevant for Statistisk sentralbyrå. labels Jun 13, 2023
@RonnyB71 RonnyB71 moved this to 👷 In Progress in Team Apps Jun 13, 2023
@RonnyB71 RonnyB71 self-assigned this Jun 13, 2023
@RonnyB71 RonnyB71 moved this from 👷 In Progress to 🔎 Review in Team Apps Jun 16, 2023
@RonnyB71 RonnyB71 moved this from 🔎 Review to 🧪 Test in Team Apps Jun 21, 2023
@RonnyB71 RonnyB71 moved this from 🧪 Test to 👷 In Progress in Team Apps Jun 27, 2023
@RonnyB71 RonnyB71 moved this from 👷 In Progress to 🔎 Review in Team Apps Jun 27, 2023
@RonnyB71 RonnyB71 moved this from 🔎 Review to 👷 In Progress in Team Apps Jun 27, 2023
@RonnyB71 RonnyB71 moved this from 👷 In Progress to 📈 Todo in Team Apps Aug 8, 2023
@RonnyB71 RonnyB71 removed their assignment Aug 14, 2023
@RonnyB71 RonnyB71 moved this from 📈 Todo to 👷 In Progress in Team Apps Aug 16, 2023
@RonnyB71 RonnyB71 self-assigned this Aug 16, 2023
@RonnyB71 RonnyB71 moved this from 👷 In Progress to 🔎 Review in Team Apps Aug 18, 2023
@RonnyB71
Copy link
Member Author

Nuget v7.14.0-preview.1 created with backend changes.

@RonnyB71 RonnyB71 moved this from 🔎 Review to 📈 Todo in Team Apps Aug 22, 2023
@RonnyB71 RonnyB71 removed their assignment Aug 22, 2023
@olemartinorg olemartinorg moved this to Todo in Issues SSB Sep 6, 2023
@Magnusrm Magnusrm moved this from 📈 Todo to 👷 In Progress in Team Apps Oct 9, 2023
@Magnusrm Magnusrm self-assigned this Oct 9, 2023
@Magnusrm Magnusrm moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 9, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues SSB Nov 14, 2023
@Magnusrm Magnusrm moved this from 🔎 Review to 🧪 Test in Team Apps Nov 14, 2023
@lassopicasso
Copy link

Tested for v3 and v4, both work nicely! Well done @Magnusrm ! 🚀

@lassopicasso lassopicasso moved this from 🧪 Test to ✅ Done in Team Apps Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users. org/ssb Issues relevant for Statistisk sentralbyrå.
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants