Fixed crash when receiving calculated changes from server #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2023 13:31
…pack dev server. There might be changes between these, so it's important we test on what arrives in prod.
…the bug triggered when saving something that calculates a new value from the server-side (which happens many other places), so there is no need for new test cases here.
olemartinorg
added
kind/bug
added 5 commits
February 22, 2023 13:39
…T we no longer need to install deps, building as its own step so that we can measure the time it takes.
…mpiles to an unreadable and unpredictable name when in production mode
…mpiles to an unreadable and unpredictable name when in production mode
|
Kudos, SonarCloud Quality Gate passed! |
olemartinorg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #899 I introduced a new feature that finds the changes from previous saves, and tracks these changes beteween saves. This works great when using the webpack dev-server (which I usually use), but when packed to a production version, Redux locks the object so that we cannot make changes to them (which is a good thing). However, our tests didn't catch that, so this PR changes the tests to run the production-ready code build instead of the local webpack development build.
The bugfix change itself is rather small, in
submitFormDataSagas.ts, so most of this PR includes the change to run Cypress on production-like code.Related Issue(s)
Verification/QA
src/layout/layout.d.tsandlayout.schema.v1.json, and these are all backwards-compatiblekind/*label to this PR for proper release notes grouping