Showing validation error in vscode when using invalid IDs for components #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As proven in #734, ending a component ID with
-5
(or any<dash><number>
) may cause trouble. Since we add state like that when components are used inside repeating groups, weird stuff will happen if you provide those kinds of IDs yourself. Since it's a very large undertaking to fix this problem in app-frontend right now, we should at least warn developers about this when they edit their layouts in vscode.Related Issue(s)
Verification
layout/index.ts
andlayout.schema.v1.json
, and these are all backwards-compatible