Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing validation error in vscode when using invalid IDs for components #758

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

olemartinorg
Copy link
Contributor

Description

As proven in #734, ending a component ID with -5 (or any <dash><number>) may cause trouble. Since we add state like that when components are used inside repeating groups, weird stuff will happen if you provide those kinds of IDs yourself. Since it's a very large undertaking to fix this problem in app-frontend right now, we should at least warn developers about this when they edit their layouts in vscode.

Related Issue(s)

Verification

  • Manual testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added
    • Cypress E2E test(s) have been added
    • No automatic tests are needed here
    • I want someone to help me make some tests
  • User documentation @ altinn-studio-docs
    • Has been updated
    • No changes/updates needed
  • Changes/additions to component properties
    • Changes are reflected in both layout/index.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board

Ole Martin Handeland added 3 commits December 15, 2022 15:50
@olemartinorg olemartinorg added the kind/bug Something isn't working label Dec 15, 2022
@olemartinorg olemartinorg merged commit 57d3bf5 into main Dec 16, 2022
@olemartinorg olemartinorg deleted the bug/preventing-broken-ids branch December 16, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamics repeating groups error
2 participants