Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying flattenObject(), adding support for non-string types #738

Closed
wants to merge 3 commits into from

Conversation

olemartinorg
Copy link
Contributor

Description

Lots of stuff will fail here, but this targets next (aka v4), so it's fine to break things for now (I think). This is the first step towards supporting non-string types. Next steps would be to make sure we look up the bound data type in the JsonSchema to know how we should store the data for a given component.

Related Issue(s)

Verification

  • Manual testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added
    • Cypress E2E test(s) have been added
    • No automatic tests are needed here
    • I want someone to help me make some tests
  • User documentation @ altinn-studio-docs
    • Has been updated
    • No changes/updates needed
  • Changes/additions to component properties
    • Changes are reflected in both layout/index.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board

…om flattenObject() function that seemed to ruin things.
@olemartinorg olemartinorg marked this pull request as draft December 12, 2022 22:01
Base automatically changed from next to main September 12, 2023 11:19
Ole Martin Handeland added 2 commits September 27, 2023 12:02
# Conflicts:
#	src/features/form/data/index.d.ts
#	src/utils/databindings.ts
@olemartinorg
Copy link
Contributor Author

Closing this one. It is very outdated now, and I'm working on supporting non-stringy data in data models when adding support for the new PATCH endpoint, so this direction is not the future I'm rooting for anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant