Bug/225 browser back button not navigating in app

[mjulstein]

Description

I changed the behavior of how the form url changes where it now puts the page id at he end of the route.
By doing so we get to listen to history-changes and re-render the Form component based on the page id inside the formLayout.

Tested in Firefox.

Related Issue(s)

• Browser back button do not apply to app pages #225

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

NOTE

The below steps (in Norwegian) do reproduce am error. However, the issue seems to be related to not being able to access pages after the allowed pages after the page order has been updated or switching layout sets:

1. Du har tidligere instanser, velg en fra listen eller start en ny. Jeg startet en ny.
2. Velkommen til frontend-test, noen beskrivelser, en knapp for å starte. Jeg trykker på knappen. (Tror URL sier /formLayout på dette tidspunktet)
3. Skjema for å endre navn. Jeg fyller ut skjemaet.
4. Oppsummeringsside for endring av navn. Jeg trykker neste.
5. Side for repeterende grupper.
6. Side for å fylle ut et tekstfelt (innmelder?).
7. Oppsummeringsside for repeterende grupper.
   Hvis du står på steg 4 og trykker tilbake, kommer du til steg 3, men hvis du står på steg 3 og går tilbake fikk jeg en feilmelding (appen kræsjet). Samme hvis jeg stod på steg 5, 6 eller 7 og prøvde å gå tilbake til steg 4.

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging 5035e38 into 140e818 - view on LGTM.com

new alerts:

• 1 for Unneeded defensive code

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 09c75ab into 140e818 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging ca00ddc into 140e818 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 2fdcb39 into 140e818 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 031418b into dbe5ed9 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 0408f0b into dbe5ed9 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 5d4b478 into 93b8938 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request fixes 1 alert when merging 4bd1a5b into 93b8938 - view on LGTM.com

fixed alerts:

• 1 for Unneeded defensive code

[olemartinorg]

Great job in cleaning up cognitive complexity and such along the way! 🥇 This looks good, but I still think we should find a way to solve the usability issue you noted in the initial description - I'm not sure we should be releasing this early at a stage where it causes (apparent) app crashes when clicking the browser back button in some apps.

[lgtm-com]

This pull request introduces 3 alerts and fixes 1 when merging 514915b into 93b8938 - view on LGTM.com

new alerts:

• 2 for Ineffective parameter type
• 1 for Superfluous trailing arguments

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request introduces 3 alerts and fixes 1 when merging f75450d into 93b8938 - view on LGTM.com

new alerts:

• 2 for Ineffective parameter type
• 1 for Superfluous trailing arguments

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request introduces 3 alerts and fixes 1 when merging f3ce986 into 93b8938 - view on LGTM.com

new alerts:

• 2 for Ineffective parameter type
• 1 for Superfluous trailing arguments

fixed alerts:

• 1 for Unneeded defensive code

[lgtm-com]

This pull request introduces 3 alerts when merging 6cbe77b into a5f1f8f - view on LGTM.com

new alerts:

• 2 for Ineffective parameter type
• 1 for Superfluous trailing arguments

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

97.7% Coverage
0.0% Duplication

[olemartinorg]

Closing this, but keeping the branch for a while. The changes here are similar to #451, which we intend to keep (but have to rewrite to keep up with the ever-changing main).