Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/1491 remove tracks functionality #1645

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Nov 13, 2023

Description

This PR removes calculatePageOrder-functionality. We will not support this feature with dynamic expressions as of right now. That need will be met with the generic button which will be able to navigate to arbitrary pages in the future.

Here is a Slack thread summarizing why we think it is ok to remove the functionality

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@mikaelrss mikaelrss added the kind/breaking-change Issue/pull request containing a breaking change label Nov 13, 2023
@mikaelrss
Copy link
Contributor Author

The Percy visual changes are because of 3 new screenshots, and becasue of some loading state in Dropdown components.

@mikaelrss mikaelrss force-pushed the chore/1491-remove-tracks-functionality branch from d9f6116 to 4c7e769 Compare November 13, 2023 13:07
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

66.0% 66.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mikaelrss mikaelrss marked this pull request as ready for review November 13, 2023 14:31
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Good riddance! 🤩

@mikaelrss mikaelrss merged commit d665373 into main Nov 14, 2023
@mikaelrss mikaelrss deleted the chore/1491-remove-tracks-functionality branch November 14, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change Issue/pull request containing a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tracks functionality (calculatePageOrder)
2 participants