Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting data model (schema + data) fetching to Tanstack Query #1425

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Sep 1, 2023

Description

While working on extending the feedback.ts test for the stateless test-app, I found that it failed to properly fetch the json schema for a new data model I added to the app. After a trip down a rabbit hole and back, I've refactored and rewritten the logic to fetch both the data model schema and current data using Tanstack Query instead of legacy Redux Sagas. It fixed the problem I had in the stateless app, so I was able to continue working on extending those tests.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@olemartinorg olemartinorg added the kind/other Pull requests containing chores/repo structure/other changes label Sep 1, 2023
@olemartinorg olemartinorg self-assigned this Sep 1, 2023
Ole Martin Handeland added 3 commits September 1, 2023 14:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

23.3% 23.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@olemartinorg olemartinorg marked this pull request as ready for review September 1, 2023 13:33
@olemartinorg olemartinorg merged commit 84579d0 into main Sep 4, 2023
@olemartinorg olemartinorg deleted the chore/rewrite-to-query branch September 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants