Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static query parameters for options #1370

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Static query parameters for options #1370

merged 6 commits into from
Aug 10, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Aug 8, 2023

Description

This introduces a new option for setting static query parameters in options (similar to mapping, but not from the data model).

This can be done by adding the queryParameters property with the form:

{
  "id": "some-id",
  "type": "Dropdown",
  "optionsId": "options",
  "queryParameters": {
    "name": "value"
  }
}

This object can be extended in the future to add expression support, but this would likely require a major rewrite, possibly by moving over to tanstack query. If and when these things happen, we could deprecate and later remove mapping.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@bjosttveit bjosttveit added the kind/product-feature Pull requests containing new features label Aug 8, 2023
@bjosttveit bjosttveit changed the title Fixed query parameters Fixed query parameters for options Aug 9, 2023
@bjosttveit bjosttveit changed the title Fixed query parameters for options Static query parameters for options Aug 9, 2023
@bjosttveit bjosttveit marked this pull request as ready for review August 9, 2023 13:28
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it! 🤩

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

92.2% 92.2% Coverage
0.0% 0.0% Duplication

@bjosttveit bjosttveit merged commit bc4fb43 into main Aug 10, 2023
@bjosttveit bjosttveit deleted the fixed-query-parameters branch August 10, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass fixed query parameters to dynamic options
2 participants