Refactoring updateRepeatingGroups
#1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 25, 2023 14:26
….ts (it contained functions for not just the form layout, but repeating groups and file uploaders)
…s for adding and removing rows. Also adding separate rejection actions for them all.
… editIndex to undefined. When these two sagas (delete row + add row) used the same function, the `index` parameter passed in was _only_ set when deleting a row (used for indicating which row to delete, but new rows are always added at the end). The thinking here was probably to set the edit index to the new row index, so I changed the code to fix that, but some tests are now failing because it is expected that the calling code handles updating the editing index (and does it conditionally).
olemartinorg
added
the
kind/other
olemartinorg
requested review from
bjosttveit,
framitdavid,
Magnusrm and
lassopicasso
bjosttveit
approved these changes
May 25, 2023
…ingGroups runs, not just the first time (fixes Likert test)
|
SonarCloud Quality Gate failed. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some refactoring to make #1175 easier to implement with a compatibility layer on top. Instead of
updateRepeatingGroupsinformLayoutSagadoing two things (both adding and removing a row from the repeating group state), this splits the two apart into separate actions (repGroupAddRowandrepGroupDeleteRow).The reason behind this change is to prepare for a cleaner interface in the future where we store this metadata about repeating groups inside the data model (for instance, the
indexstate should be derived from the data model itself, as it is essentially thelengthof the repeating groups array). To make this change more cleanly, we should prepare our existing code for the changes to come.Sadly, the diffs here on github are pretty useless for this change, as most of this is just moving around code with automated 'extract to function', moving functions into other folders, indentation changes, etc. Sorry!
Related Issue(s)
Verification/QA
src/layout/layout.d.tsandlayout.schema.v1.json, and these are all backwards-compatiblekind/*label to this PR for proper release notes grouping