Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/989 timing issue regarding updating data stateless app #1067

Merged

Conversation

framitdavid
Copy link
Contributor

@framitdavid framitdavid commented Mar 30, 2023

Description

Ensure to cancel previous requests for stateless apps to avoid updating the redux state with staled data.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@framitdavid framitdavid changed the title Bug/989 timing issue regarding updating data state less app Bug/989 timing issue regarding updating data stateless app Mar 30, 2023
@framitdavid framitdavid marked this pull request as ready for review March 30, 2023 11:29
@framitdavid framitdavid added the kind/bug Something isn't working label Mar 30, 2023
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 🚀 Maybe we could add a regression test for this using Cypress? We have a couple of stateless apps we could extend with some checkboxes/radios, and Cypress is definitely fast enough for us to not have to bother with any request throttling.. 😉 At some point, when we implement #345 we might not have sagas anymore, so it's important we don't end up re-implementing this bug at that point.

@framitdavid
Copy link
Contributor Author

Good stuff! 🚀 Maybe we could add a regression test for this using Cypress? We have a couple of stateless apps we could extend with some checkboxes/radios, and Cypress is definitely fast enough for us to not have to bother with any request throttling.. 😉 At some point, when we implement #345 we might not have sagas anymore, so it's important we don't end up re-implementing this bug at that point.

Thanks! 🙏 I agree with you that it’s important to have a cypress test for this fix within one of our stateless apps. I fix.

Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good! 🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

16.7% 16.7% Coverage
0.0% 0.0% Duplication

@framitdavid framitdavid merged commit 8740a58 into main May 2, 2023
@framitdavid framitdavid deleted the bug/989_TimingIssueRegardingUpdatingDataStateLessApp branch May 2, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing issue regarding updating the data model (Stateless)
2 participants