-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/989 timing issue regarding updating data stateless app #1067
Bug/989 timing issue regarding updating data stateless app #1067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 🚀 Maybe we could add a regression test for this using Cypress? We have a couple of stateless apps we could extend with some checkboxes/radios, and Cypress is definitely fast enough for us to not have to bother with any request throttling.. 😉 At some point, when we implement #345 we might not have sagas anymore, so it's important we don't end up re-implementing this bug at that point.
Thanks! 🙏 I agree with you that it’s important to have a cypress test for this fix within one of our stateless apps. I fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good! 🚀
SonarCloud Quality Gate failed. |
Description
Ensure to cancel previous requests for stateless apps to avoid updating the redux state with staled data.
Related Issue(s)
Verification/QA
src/layout/layout.d.ts
andlayout.schema.v1.json
, and these are all backwards-compatiblekind/*
label to this PR for proper release notes grouping