Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from hash-router to browser-router #344

Closed
7 of 12 tasks
Tracked by #196
mjulstein opened this issue Jul 18, 2022 · 1 comment
Closed
7 of 12 tasks
Tracked by #196

Switch from hash-router to browser-router #344

mjulstein opened this issue Jul 18, 2022 · 1 comment
Assignees
@mjulstein
Labels
area/accessibility related to WCAG and accessibility kind/feature-request New feature or request status/triage

Comments

@mjulstein
Copy link
Contributor

mjulstein commented Jul 18, 2022 •
edited
Loading

Description

Currently we are using HashRouter as our React-Router option in Apps (and other solutions.)
The drawback of this is that we loose the ability to comply with modern accessibility requirements such as landmarks.
HashRouter is no longer recommended by the React-Router either.

Upgrade to React-Router v6

React Router 6 has changes that would require re-write of the changes required to switch to BrowserRouter.

Related issues:

Requirements:

The applications no longer use HashRouter and the following App-Configurations work as expected (before):

  • State-full apps
  • State-less apps
  • Anonymous State-less apps

Additional tasks:

  • Edit the LandmarkShortcut component to make use of the router switch.
  • Update to latest version of react-router

Additional Information

No response
@mjulstein mjulstein added kind/feature-request New feature or request area/accessibility related to WCAG and accessibility ux/wcag status/triage labels Jul 18, 2022
@mjulstein mjulstein self-assigned this Jul 18, 2022
This was referenced Jul 21, 2022
Merged
Closed
@mjulstein mjulstein moved this to Todo in Team Studio (old) Jul 23, 2022
@mjulstein mjulstein moved this from Todo to In Progress in Team Studio (old) Jul 25, 2022
@mjulstein mjulstein pinned this issue Jul 25, 2022
@mjulstein mjulstein mentioned this issue Aug 10, 2022
Closed
@lorang92 lorang92 unpinned this issue Aug 18, 2022
@mjulstein mjulstein moved this from In Progress to Todo in Team Studio (old) Sep 12, 2022
@mjulstein
Copy link
Contributor Author

Moved this issue out of current sprints as it's not prioritized for now. Some of the subtasks need to be done though.

@FinnurO FinnurO mentioned this issue Oct 5, 2022
Open
8 tasks
@tjololo tjololo mentioned this issue Dec 21, 2022
Closed
@Febakke Febakke removed the ux/wcag label Apr 17, 2023
@RonnyB71 RonnyB71 mentioned this issue Oct 10, 2023
Open
@mjulstein mjulstein closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjulstein mjulstein

Labels
area/accessibility related to WCAG and accessibility kind/feature-request New feature or request status/triage
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

sabbatical/344-switch-from-hash-router-to-browser-router Altinn/app-frontend-react
2 participants
@mjulstein @Febakke