Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout settings for receipt pages and instance selection #1686

Closed
mikaelrss opened this issue Dec 5, 2023 · 1 comment · Fixed by #1712 or #1717
Closed

Layout settings for receipt pages and instance selection #1686

mikaelrss opened this issue Dec 5, 2023 · 1 comment · Fixed by #1712 or #1717
Assignees
Labels
fe-v4 Issues to be solved before v4 goes gold kind/bug Something isn't working status/triage

Comments

@mikaelrss
Copy link
Contributor

mikaelrss commented Dec 5, 2023

Description of the bug

Currently. There is no way of setting the showLanguageSelector or hideCloseButton pages that are not a part of a layout set. #1682 Refactores these settings to use a UiConfigContext. This highlighed a new problem. The current way of fetching these values uses the layout settings, which mean that, for instance showLanguageSelector can only be specified in a layout set. This means that for instance selection and receipt pages, there is no way of showing the language selector. This worked previously because the settings of the last page was stored in redux and subsequently used in the receipt page.

Steps To Reproduce

No steps to reproduce, but the app developers do not have a way of specifying whether the language selector should be visible on pages outside layout settings.

Additional Information

We need to agree on an API for the app developers to be able to set these settings also outside of the current layout set.

@mikaelrss mikaelrss added kind/bug Something isn't working status/triage labels Dec 5, 2023
@olemartinorg olemartinorg self-assigned this Jan 2, 2024
@olemartinorg olemartinorg moved this to 👷 In Progress in Team Apps Jan 2, 2024
@olemartinorg
Copy link
Contributor

As noted in #1712, I think I have a fix in place for this already there. I'll put me as assigned to this issue and be sure to write tests for it.

@olemartinorg olemartinorg moved this from 👷 In Progress to 🔎 Review in Team Apps Jan 4, 2024
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Jan 4, 2024
@olemartinorg olemartinorg moved this from 🔎 Review to 🧪 Test in Team Apps Jan 8, 2024
@mikaelrss mikaelrss self-assigned this Jan 9, 2024
@mikaelrss mikaelrss moved this from 🧪 Test to ✅ Done in Team Apps Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-v4 Issues to be solved before v4 goes gold kind/bug Something isn't working status/triage
Projects
Archived in project
2 participants