Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tracks functionality (calculatePageOrder) #1491

Closed
2 tasks done
Tracked by #339 ...
olemartinorg opened this issue Sep 25, 2023 · 5 comments · Fixed by #1645
Closed
2 tasks done
Tracked by #339 ...

Remove tracks functionality (calculatePageOrder) #1491

olemartinorg opened this issue Sep 25, 2023 · 5 comments · Fixed by #1645
Assignees
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Sep 25, 2023

In #339 we discussed removing the older tracks functionality (calculatePageOrder). See discussions below. If we remove that support, we should ensure app developers are notified in DevTools when still using the configuration option in triggers. We should also make sure we support all use-cases using newer expressions - especially changing the page order in some way. It seems we already have some (undocumented) support for changing the page order using ILayoutNavigation (search for that type and its usages), where the next page can be configured per-layout file. If we enhance these properties to support expressions, we should be covered enough to be able to remove support for calculatePageOrder.

Discussion:

Relevant issues:

Tasks

Preview Give feedback
  1. fe-v4
    mikaelrss
  2. fe-v4
    mikaelrss
@olemartinorg olemartinorg added the kind/breaking-change Issue/pull request containing a breaking change label Sep 25, 2023
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@RonnyB71
Copy link
Member

RonnyB71 commented Oct 3, 2023

This issue implies hiding and reordering of pages. Hiding is supported with expressions, while we need to look into the usage of reordering - are there any real cases of reordering of pages?

@olemartinorg
Copy link
Contributor Author

I've read through 78 classes implementing IPageOrder, and I found no logic in any of them that could not be re-implemented using expressions. 🥳 Especially after commaContains arrived. Most classes have fairly simple logic that could be very easily replicated using expressions (removing a few pages based on data model lookups and equality comparisons), but some have a bit more advanced results (choosing between a larger range of different tracks), although the logic itself is still very simple (i.e. comparing form data with fixed strings). Crucially, I found no examples where the actual page order is altered, this functionality seems to only be used for hiding/showing certain pages.

@RonnyB71
Copy link
Member

Oppdatere:

  • Kurs
  • Dokumentasjon
  • Eksempler på uttryk
  • Oppådatere converterings tool

Fjernes fra frontend

TImebox for å teste ut automatikk

@HanneLauritsen1967 HanneLauritsen1967 moved this to 📈 Todo in Team Apps Oct 24, 2023
@olemartinorg olemartinorg removed the status in Team Apps Nov 3, 2023
@mikaelrss mikaelrss self-assigned this Nov 8, 2023
@mikaelrss mikaelrss moved this to 👷 In Progress in Team Apps Nov 8, 2023
@mikaelrss mikaelrss moved this to 🏗 In progress in Digital gravferdsmelding Nov 9, 2023
@mikaelrss mikaelrss moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 13, 2023
@mikaelrss mikaelrss moved this from 🏗 In progress to 👀 In review in Digital gravferdsmelding Nov 14, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital gravferdsmelding Nov 14, 2023
@mikaelrss mikaelrss moved this from 🔎 Review to 🧪 Test in Team Apps Nov 15, 2023
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Nov 15, 2023
@olemartinorg
Copy link
Contributor Author

Re-opening. As mentioned above, we also need a strategy for migrating existing apps, update documentation, etc.

@olemartinorg olemartinorg reopened this Nov 15, 2023
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
@olemartinorg olemartinorg removed the status in Team Apps Nov 23, 2023
@RonnyB71 RonnyB71 moved this to 👷 In Progress in Team Apps Jan 2, 2024
@RonnyB71 RonnyB71 moved this from 👷 In Progress to ⚠️ Blocked in Team Apps Jan 5, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from ⚠️ Blocked to 🧪 Test in Team Apps Jan 12, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ⚠️ Blocked in Team Apps Jan 22, 2024
@mikaelrss mikaelrss moved this from ⚠️ Blocked to 📈 Todo in Team Apps Feb 14, 2024
@mikaelrss mikaelrss moved this from 📈 Todo to 👷 In Progress in Team Apps Feb 29, 2024
@mikaelrss mikaelrss moved this from 👷 In Progress to 🔎 Review in Team Apps Mar 22, 2024
@RonnyB71 RonnyB71 moved this from 🔎 Review to 🧪 Test in Team Apps Mar 22, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Mar 25, 2024
@olemartinorg
Copy link
Contributor Author

Closing this issue as either stale/outdated or done now. Let me know if you disagree @mikaelrss 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants