Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite useGetOptions() and data lists to hooks using Tanstack Query without Redux #1294

Closed
Tracked by #1094 ...
olemartinorg opened this issue Jun 29, 2023 · 2 comments · Fixed by #1442
Closed
Tracked by #1094 ...
Assignees
Labels
fe-v4 Issues to be solved before v4 goes gold quality/debt

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Jun 29, 2023

It should be possible just to pass in all the different props (options, optionsId, source and mapping) and just return IOption[] (or whatever it's called). No need for Redux.

Same goes for data lists, which is very similar to regular options.

Links to relevant issues

@RonnyB71
Copy link
Member

Verify the PDF implementation as this depends on sagas fetching options.

@Magnusrm Magnusrm moved this to 📈 Todo in Team Apps Aug 21, 2023
@lassopicasso lassopicasso moved this from 📈 Todo to 👷 In Progress in Team Apps Aug 22, 2023
@lassopicasso lassopicasso linked a pull request Sep 8, 2023 that will close this issue
19 tasks
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@lassopicasso lassopicasso moved this from 👷 In Progress to 🔎 Review in Team Apps Sep 29, 2023
@lassopicasso lassopicasso moved this from 🔎 Review to 🧪 Test in Team Apps Oct 2, 2023
@bjosttveit bjosttveit moved this from 🧪 Test to ✅ Done in Team Apps Oct 10, 2023
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-v4 Issues to be solved before v4 goes gold quality/debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants