9360 receipt editor navigation with query params #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
solution/studio/designer
|
This pull request introduces 1 alert when merging e559148 into 03bebcd - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
mijohansen
force-pushed
the
9360-receipt-editor-navigation-with-query-params
branch
from
9c2ee22 to
018b51a
Compare
TomasEng
requested changes
Dec 8, 2022
mjulstein
approved these changes
Dec 8, 2022
TomasEng
approved these changes
Dec 8, 2022
mijohansen
deleted the
9360-receipt-editor-navigation-with-query-params
branch
standeren
pushed a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds query parameter navigation. Due to some heavy binding between the selectedLayout and the state we are keeping the selectedLayout in the state. This should probably be cleaned at a later point so that the current selectedLayout is something that is managed by this
layout-query parameter in its whole.This is a pre-requisite for adding the "Confirmation on screen"-task. As this will make it possible to work on a particular page without loosing context as we refresh the page.
Related Issue(s)
Verification
Documentation