-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added layout options for checkboxes and radio(row/column) #8238
Conversation
…box layout if they want.
Some code not included |
This pull request introduces 1 alert when merging 235c6b9 into 439f58b - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9f18d7b into 8dcca8f - view on LGTM.com new alerts:
|
…eckbox and radio component, and add tests
@lorang92 I think this is ready to go now. WDYT about naming, is it ok? We also discussed using |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
@haakemon code looks great. The naming part is difficult, I'm ok with both suggestions really. Would be very neat if app developers could configure row/column layout in studio, but maybe that can be done as a separate issue? And finally, I think we should create a new issue to support column-based options as mentioned by DAT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🥳
Studio implementation should be a separate issue: #8310 Ill add some PR's soon with updated docs and updated json schema for this feature. |
Kudos, SonarCloud Quality Gate passed! |
Description
Due to requests from users of manually deciding for layout style in radio and checkboxes, it now supports
column or row direction. However it does not support multicolumns, but only a single column.
layout
option added for radio and checkboxes. App developers can explicitly decide if these items should be laid out on a row, or as a column. The default is still less than 3 options it will be displayed as a row.LayoutStyle
enum is added withRow
andColumn
options. This is to make it easier to extend in the future if we want to introduce f.exGrid
layout.Fixes
Verification
Documentation