Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4629 create frontend template #4658

Merged
merged 7 commits into from
Aug 25, 2020

Conversation

nkylstad
Copy link
Member

Altinn/app-frontend-react#200
Copied standard app template code into template folder, and simplified folder structure:

  • Removed all specific process step views, replaced with a CustomView that can is a starting point for custom fromtend

  • Removed unnecessary code relating to form

    • components
    • rules/dynamics
    • layout
  • Simplified folder structure

    • removed shared folder and moved contents out one level
    • added redux folder to contain saga/reducer/store definition

Copy link
Contributor

@acn-sbuad acn-sbuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 25, 2020

This pull request introduces 12 alerts when merging c9ea21b into 6f39d99 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class
  • 4 for Useless conditional
  • 3 for Ambiguous HTML id attribute

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 25, 2020

This pull request introduces 12 alerts when merging f8c5252 into 6f39d99 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class
  • 4 for Useless conditional
  • 3 for Ambiguous HTML id attribute

@nkylstad nkylstad merged commit 91c4bd1 into master Aug 25, 2020
@nkylstad nkylstad deleted the feature/4629-create-frontend-template branch August 25, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants