Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-editor: Hover state get stuck on DND #8897

Closed
mijohansen opened this issue Sep 1, 2022 · 1 comment
Closed

ui-editor: Hover state get stuck on DND #8897

mijohansen opened this issue Sep 1, 2022 · 1 comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.

Comments

@mijohansen
Copy link
Contributor

When dragging and dropping elements in the ui-editor the hoverstate is not changed. This means that the background of the element at the position of the dragged item is white and the Editbutton is still there. Problem is observerd i chrome, and widely discussed amoung react-dnd-users.

image.png

I think this is due to the fact that the view is using hover state to display these features instead of manualy using onMouseEnter / onMouseLeave and just propagate the hover-state to subcomponents manually displaying the items that should be showed:

image (1).png

There are several benefits of going with the non-css alternative. You get better control over components and how they are displayed and needless to say, its easier to make tools accessible. Its really the focus of an element that should display the buttons, not the hover state.

Its also easier to test, as the state could be showed programmaticly.

@mijohansen mijohansen added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Sep 1, 2022
@mijohansen mijohansen changed the title ux-editor: Hover state get stuck on DND ui-editor: Hover state get stuck on DND Sep 1, 2022
@mijohansen
Copy link
Contributor Author

This one is not relevant as @TomasEng have changed this area of the code... se #9218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.
Projects
None yet
Development

No branches or pull requests

1 participant