Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3 Adding the option of searching for instances based on person or org number, or other in storage #360

Merged
merged 31 commits into from
Apr 11, 2024
Merged

#3 Adding the option of searching for instances based on person or org number, or other in storage #360

merged 31 commits into from
Apr 11, 2024

Conversation

khanrn
Copy link
Contributor

@khanrn khanrn commented Mar 25, 2024 •
edited
Loading

Adding the option of searching for instances based on person or org number, or other in storage

Description

Adding the option of searching for instances based on person or org number, or other in storage

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@khanrn khanrn requested a review from SandGrainOne April 2, 2024 07:30
@khanrn khanrn marked this pull request as ready for review April 8, 2024 12:09
khanrn added 19 commits April 9, 2024 20:55
@khanrn
RegisterService client added
edbfcf2
@khanrn
Party ID look up with register service client
88e9138
@khanrn
Fixed issues and typos
b98d9ed
@khanrn
IAccessTokenGenerator added as singleton
695a521
@khanrn
RegisterService test added
54a45fe
@khanrn
Username removed from haystack
fe36cb6
@khanrn
Tests added for GetIdentifierFromInstanceOwnerIdentifier
e800c38
@khanrn
GetIdentifierFromInstanceOwnerIdentifier refactored
ab22b0a
@khanrn
ApiRegisterEndpoint value added for test
e0ccd48
@khanrn
JwtCookieName value added to appsettings
61bb327
@khanrn
Fixed the namespace for platform settings
9de8c87
@khanrn
Changed expected text in the test
44db598
@khanrn
SonarCloud issue fix
e077c92
@khanrn
Test added for GetParty
0f25bc7
@khanrn
Test fixed with proper arguments
6dae234
@khanrn
Test update
e742957
@khanrn
Contains firxed the test issue
209a887
@khanrn
Test for log error passed
2ec6905
@khanrn
Party ID update on the query parameters
fd47008
@khanrn khanrn requested a review from SandGrainOne April 10, 2024 11:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanrn khanrn requested a review from SandGrainOne April 11, 2024 12:13
@khanrn khanrn merged commit 7375a4a into main Apr 11, 2024
9 checks passed
@khanrn khanrn deleted the fix/3 branch April 11, 2024 15:24
This was referenced Apr 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

@acn-dgopa acn-dgopa acn-dgopa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khanrn @SandGrainOne @acn-dgopa