Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests that include use of a PostgreSQL server fails when the PR is based on a fork #567

Open
2 tasks
SandGrainOne opened this issue Nov 26, 2024 · 0 comments
Labels
status/draft Status: When you create an issue before you have enough info to properly describe the issue.

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Nov 26, 2024

Description

A lot of the tests we have in Storage doesn't run successfully when the pull requests comes from a fork. We need to find a good and safe way of setting up a PostgreSQL server that can be used.

Additional Information

Build and analysis of pull requests that comes from a fork needs to run by different agents and with limited access to our resources. Github workflows can be a popular attack vector against our systems. Workflows running in a pull request will be using the workflow definition defined in the source branch. An attacker could use this to gain access to our systems.

Tasks

Acceptance Criterias

  • A pull request from a fork can be properly tested and analyzed
@SandGrainOne SandGrainOne added the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/draft Status: When you create an issue before you have enough info to properly describe the issue.
Projects
None yet
Development

No branches or pull requests

1 participant