negate the property names for data type creation and deletion (#487)

Altinn · Sep 5, 2024 · 1f3a8ed · 1f3a8ed
1 parent da2c498
commit 1f3a8ed
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/src/Storage.Interface/Models/ApplicationLogic.cs b/src/Storage.Interface/Models/ApplicationLogic.cs
@@ -41,18 +41,18 @@ public class ApplicationLogic
         public bool AutoDeleteOnProcessEnd { get; set; }
 
         /// <summary>
-        /// Specifies whether users should be able to create data of this type.
+        /// Specifies whether users should be unable to create data of this type.
         /// Defaults to false if not specified.
         /// </summary>
-        [JsonProperty(PropertyName = "allowUserCreate")]
-        public bool AllowUserCreate { get; set; }
+        [JsonProperty(PropertyName = "disallowUserCreate")]
+        public bool DisallowUserCreate { get; set; }
 
         /// <summary>
-        /// Specifies whether users should be able to delete data of this type.
+        /// Specifies whether users should be unable to delete data of this type.
         /// Defaults to false if not specified.
         /// </summary>
-        [JsonProperty(PropertyName = "allowUserDelete")]
-        public bool AllowUserDelete { get; set; }
+        [JsonProperty(PropertyName = "disallowUserDelete")]
+        public bool DisallowUserDelete { get; set; }
 
         /// <summary>
         /// Specifies whether the data type is compatible with sub form usage.

diff --git a/...tinn.Platform.Storage.Interface.Tests/AllowInSubform/applicationMetadata_afterChange.json b/...tinn.Platform.Storage.Interface.Tests/AllowInSubform/applicationMetadata_afterChange.json
@@ -23,8 +23,8 @@
             "appLogic": {
                 "autoCreate": true,
                 "classRef": "Altinn.App.Models.StarteBedrift",
-                "allowUserCreate": true,
-                "allowUserDelete": true,
+                "disallowUserCreate": false,
+                "disallowUserDelete": false,
                 "allowInSubform": true
             },
             "taskId": "Task_1",

diff --git a/...inn.Platform.Storage.Interface.Tests/AllowInSubform/applicationMetadata_beforeChange.json b/...inn.Platform.Storage.Interface.Tests/AllowInSubform/applicationMetadata_beforeChange.json
@@ -23,8 +23,8 @@
             "appLogic": {
                 "autoCreate": true,
                 "classRef": "Altinn.App.Models.StarteBedrift",
-                "allowUserCreate": true,
-                "allowUserDelete": true
+                "disallowUserCreate": false,
+                "disallowUserDelete": false
             },
             "taskId": "Task_1",
             "maxCount": 1,

diff --git a/test/Altinn.Platform.Storage.Interface.Tests/AllowUserActions/AllowUserActions.cs b/test/Altinn.Platform.Storage.Interface.Tests/AllowUserActions/AllowUserActions.cs
@@ -12,16 +12,16 @@ public void MetadataWithoutShadowFields_ShouldBeFalse()
     {
         Application applicationBefore = TestdataHelper.LoadDataFromEmbeddedResourceAsType<Application>("AllowUserActions.applicationMetadata_beforeChange.json");
 
-        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.AllowUserCreate.Should().BeFalse();
-        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.AllowUserDelete.Should().BeFalse();
+        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.DisallowUserCreate.Should().BeFalse();
+        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.DisallowUserDelete.Should().BeFalse();
     }
 
     [Fact]
     public void MetadataWithShadowFields_ShouldBeTrue()
     {
         Application applicationBefore = TestdataHelper.LoadDataFromEmbeddedResourceAsType<Application>("AllowUserActions.applicationMetadata_afterChange.json");
 
-        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.AllowUserCreate.Should().BeTrue();
-        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.AllowUserDelete.Should().BeTrue();
+        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.DisallowUserCreate.Should().BeTrue();
+        applicationBefore.DataTypes.First(d => d.Id == "Veileder").AppLogic.DisallowUserDelete.Should().BeFalse();
     }
 }
diff --git a/...nn.Platform.Storage.Interface.Tests/AllowUserActions/applicationMetadata_afterChange.json b/...nn.Platform.Storage.Interface.Tests/AllowUserActions/applicationMetadata_afterChange.json
@@ -23,8 +23,8 @@
       "appLogic": {
         "autoCreate": true,
         "classRef": "Altinn.App.Models.StarteBedrift",
-        "allowUserCreate": true,
-        "allowUserDelete": true
+        "disallowUserCreate": true,
+        "disallowUserDelete": false
       },
       "taskId": "Task_1",
       "maxCount": 1,