Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps should be stored in UTC format #260

Open
bdb-dd opened this issue Jan 6, 2023 · 2 comments
Open

Timestamps should be stored in UTC format #260

bdb-dd opened this issue Jan 6, 2023 · 2 comments
Labels
kind/chore Non functional, often repeating tasks. status/draft Status: When you create an issue before you have enough info to properly describe the issue.

Comments

@bdb-dd
Copy link
Contributor

bdb-dd commented Jan 6, 2023

Description

Check data transfer objects for DateTime properties and convert to DateTimeOffset to avoid serializing with local time zone offset.

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

@bdb-dd bdb-dd added status/draft Status: When you create an issue before you have enough info to properly describe the issue. kind/chore Non functional, often repeating tasks. labels Jan 6, 2023
@olebhansen
Copy link

@bdb-dd : Can you elaborate a bit on how this is having an impact? Where/how did you observe it? My understanding is that UTC is already in use (and with our external API being JSON-based, the DTO de-serialization is left to the consumer).

@bdb-dd
Copy link
Contributor Author

bdb-dd commented Jul 8, 2024

@bdb-dd : Can you elaborate a bit on how this is having an impact? Where/how did you observe it? My understanding is that UTC is already in use (and with our external API being JSON-based, the DTO de-serialization is left to the consumer).

As far as I can remember, this was mostly for improving correlation across the timestamps available internally. Pretty sure I added this after spending time looking for an event, only to discover that my filter range was off by two hours.

I believe this is an example of a timestamp that would be in local time, which can make it hard to correlate with other values stored in UTC.

The other examples I am able to find now are limited to tests.
https://github.com/search?q=repo%3AAltinn%2Faltinn-events+DateTime.Now&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Non functional, often repeating tasks. status/draft Status: When you create an issue before you have enough info to properly describe the issue.
Projects
None yet
Development

No branches or pull requests

2 participants