Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React nodes in checkboxes and radio buttons #254

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Jan 9, 2023

Description

  • Switched type from string to ReactNode on labels, descriptions and legends related to checkboxes and radio buttons
  • Added presentation property to checkbox and radio components for adding a presentation role in preview mode

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

@codecov-commenter
Copy link

Codecov Report

Base: 94.04% // Head: 94.02% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ee2164d) compared to base (da71c71).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   94.04%   94.02%   -0.02%     
==========================================
  Files          82       82              
  Lines        1142     1139       -3     
  Branches      339      341       +2     
==========================================
- Hits         1074     1071       -3     
  Misses         59       59              
  Partials        9        9              
Impacted Files Coverage Δ
src/components/Checkbox/Checkbox.tsx 85.71% <ø> (ø)
src/components/CheckboxGroup/CheckboxGroup.tsx 100.00% <ø> (ø)
src/components/FieldSet/FieldSet.tsx 100.00% <ø> (ø)
src/components/RadioButton/RadioButton.tsx 100.00% <ø> (ø)
src/components/Map/Map.tsx 90.00% <100.00%> (-1.43%) ⬇️
src/components/RadioGroup/RadioGroup.tsx 100.00% <100.00%> (ø)
...s/_CheckboxRadioTemplate/CheckboxRadioTemplate.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TomasEng TomasEng marked this pull request as ready for review January 9, 2023 10:19
@TomasEng TomasEng requested a review from Magnusrm January 9, 2023 10:25
@TomasEng TomasEng merged commit 7314361 into main Jan 9, 2023
@TomasEng TomasEng deleted the feature/react_nodes_in_checkboxes_and_radio_buttons branch January 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants