Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app identity for deployment of storage accounts #441

Merged
merged 11 commits into from
May 22, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented May 22, 2024

Description

We change deployment of app to use subscription scope so that we can use RBAC to give container app access to deploying storage accounts instead of using a separate service principal for it.

This way we avoid using any more secrets than necessary.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ceredron Ceredron marked this pull request as ready for review May 22, 2024 11:39
@Ceredron Ceredron merged commit 4c5ca21 into main May 22, 2024
5 checks passed
@Ceredron Ceredron deleted the feat/managed-identity-for-deploy branch May 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants