Legacy file uploads also need content length (#598)

Altinn · Nov 28, 2024 · e3489c8 · e3489c8
1 parent e8ffeee
commit e3489c8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Altinn.Broker.API/Controllers/LegacyFileController.cs b/src/Altinn.Broker.API/Controllers/LegacyFileController.cs
@@ -71,12 +71,16 @@ CancellationToken cancellationToken
 
         LogContextHelpers.EnrichLogsWithToken(legacyToken);
         logger.LogInformation("Legacy - Uploading file for file transfer {fileId}", fileTransferId.ToString());
-        Request.EnableBuffering();
+        if (Request.ContentLength is null)
+        {
+            return Problem("Content-length header is required");
+        }
         var commandResult = await handler.Process(new UploadFileRequest()
         {
             FileTransferId = fileTransferId,
             Token = legacyToken,
             UploadStream = Request.Body,
+            ContentLength = Request.ContentLength.Value,
             IsLegacy = true
         }, HttpContext.User, cancellationToken);
         return commandResult.Match(

diff --git a/tests/Altinn.Broker.Tests/LegacyFileControllerTests.cs b/tests/Altinn.Broker.Tests/LegacyFileControllerTests.cs
@@ -64,6 +64,7 @@ public async Task InitializeAndUpload_Success()
         }
         var fileAfterUpload = await _legacyClient.GetFromJsonAsync<LegacyFileOverviewExt>($"broker/api/v1/legacy/file/{fileId}?onBehalfOfConsumer={onBehalfOfConsumer}", _responseSerializerOptions);
         Assert.NotNull(fileAfterUpload);
+        Assert.True(fileAfterUpload.FileSize == uploadedFileBytes.Length);
         Assert.Equal(LegacyFileStatusExt.Published, fileAfterUpload.FileStatus); // When running integration test this happens instantly as of now.
     }