Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute PolicyRepository with PolicyFactory and add CancellationToken #777

Merged
merged 19 commits into from
Aug 14, 2024

Conversation

andreasisnes
Copy link
Contributor

@andreasisnes andreasisnes commented Aug 9, 2024

add cancellation token to all actions and propegate it downstream that utilize policy repository implementation.

  • Single rights delegations
  • Maskinporten delegations
  • PAP
  • PIP

Related Issue(s)

Developer/Reviewer Checklist

  • Your code builds clean without any errors or warnings
  • No changes to config/appsettings or environment variables created in separate linked PR
  • Manual testing done (required)
  • Relevant integration test added (required for functional changes)
  • Relevant automated test added (required for functional changes)
  • All integration tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.2% Coverage on New Code (required ≥ 65%)
50.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@andreasisnes andreasisnes merged commit 52e27b5 into main Aug 14, 2024
7 of 9 checks passed
@andreasisnes andreasisnes deleted the features/759#2 branch August 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants