Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MEAN values with commas in removeBadImages.sh #4303

Open
EricClaeys opened this issue Feb 9, 2025 · 0 comments
Open

Handle MEAN values with commas in removeBadImages.sh #4303

EricClaeys opened this issue Feb 9, 2025 · 0 comments
Assignees
Labels
bug Needs software change In testing Change being tested by the Allsky team

Comments

@EricClaeys
Copy link
Collaborator

Discussed in #4302

Originally posted by DC1RS February 9, 2025
After updating to v2024.12.06_01, I keep getting the message “Multiple consecutive bad images. Check the values of 'Bad image removal threshold low', 'Bad image removal threshold high' and 'Maximum auto exposure' in the WebUI.” with the same settings that worked fine with v2024.12.06 (0.1/0.9).
If I deactivate “Remove Bad Images Threshold Low / High” with 0, allsky starts up.

There is an issue with the Locale settings. I usually use de_DE.UTF-8, so decimal separator is comma instead of dot.
Now with v2024.12.06_01 there's an error message in allsky_log.txt:
2025-02-09T15:11:15.871062+01:00 allsky allsky[21142]: removeBadImages.sh: File is bad: removed 'image-20250209151112.jpg' (MEAN of 0,504436 is below low threshold of 0.1).
Changing the Locale to en_EN.UTF-8 fixed the problem.
Strangely it was working with de_DE.UTF-8 in v2024.12.06.

BR
Roland
support-none-20250209151111.zip

When a comma is used for the decimal separator, the capture program returns a MEAN with a comma. However, users have periods in the Bad Image Removal Thresholds, so removeBadImages.sh needs to handle commas in the MEAN.

@EricClaeys EricClaeys added bug Needs software change enhancement labels Feb 9, 2025
@EricClaeys EricClaeys self-assigned this Feb 9, 2025
@EricClaeys EricClaeys added In testing Change being tested by the Allsky team and removed enhancement labels Feb 9, 2025
@EricClaeys EricClaeys added this to the v2024.12.06_02 milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs software change In testing Change being tested by the Allsky team
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant