Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to speed up ISR #159

Open
t0mpr1c3 opened this issue Sep 28, 2023 · 1 comment · May be fixed by #154
Open

Suggestion to speed up ISR #159

t0mpr1c3 opened this issue Sep 28, 2023 · 1 comment · May be fixed by #154
Assignees
@t0mpr1c3
Labels
code quality

Comments

@t0mpr1c3
Copy link
Contributor

t0mpr1c3 commented Sep 28, 2023 •
edited
Loading

KH270 does not have a concept of beltshift, so we can possibly save a few cycles in the ISR by not performing digitalread(ENC_PIN_C) or setting Encoders::m_beltShift when the machine is KH270.
@t0mpr1c3 t0mpr1c3 linked a pull request Sep 29, 2023 that will close this issue
Finite Machine states inherit from OpInterface #154
Draft
@t0mpr1c3
Copy link
Contributor Author

Solution rolled into #154

@t0mpr1c3 t0mpr1c3 self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0mpr1c3 t0mpr1c3

Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finite Machine states inherit from OpInterface t0mpr1c3/ayab-firmware
1 participant
@t0mpr1c3