External Pythia8+Powheg generator #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackal1-66
requested review from
sawenzel,
chiarazampolli,
benedikt-voelkel and
a team
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Thanks a lot @jackal1-66 ! |
vkucera
reviewed
Jan 24, 2025
|
The CI failing is fixed by alisw/alidist#5745, waiting for the merging to retest |
sawenzel
reviewed
Jan 28, 2025
|
All CI tests passing, can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator has been tested using both o2-sim and the normal workflow system.
Nothing to report with normal o2-sim, however for the workflow system I noticed that it's not possible
to configure properly the parameters in the funcName => There might be a small bug that doesn't allow " to be used or that discards it. With the workflow framework both the configuration via iniFile and hybrid JSON worked flawlessly.