Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs problem creation #160

Merged
merged 42 commits into from
Jan 8, 2024
Merged

Docs problem creation #160

merged 42 commits into from
Jan 8, 2024

Conversation

Benezivas
Copy link
Collaborator

This PR adds documentation for creating problems. It discusses the basic interaction between the algobattle framework and problem files and walks the reader through the creation of a concrete, new problem.

Still missing and only added as a stub in this PR is the discussion on using alternative I/O formats other than JSON. I am not familiar enough with the framework to have the authority to discuss this topic, but deem it important that this should be discussed in this context. Please do not merge this PR until this is resolved.

@Benezivas Benezivas requested a review from ImogenBits January 1, 2024 13:15
@ImogenBits
Copy link
Collaborator

ImogenBits commented Jan 5, 2024

I added some more things and reshuffled the file structure a bit. This now includes details on custom I/O formatting, using type annotations, and some other advanced features.

Note that this PR now is dependent on #161.

@Benezivas
Copy link
Collaborator Author

Thank you very much for these additional changes and many additions, this goes well beyond what I set out to document. I like the restructuring that you did, the separation between student and instructor material, as well as additional content, is now much clearer. From my point of view this branch is ready to merge. I would also vote for creating a new minor release afterwards.

@ImogenBits
Copy link
Collaborator

ImogenBits commented Jan 8, 2024

yeah that looks good. I've made another PR, #162, that I'd also include in the new release.

@ImogenBits ImogenBits merged commit 42d2160 into main Jan 8, 2024
2 checks passed
@Benezivas Benezivas deleted the docs_problem_creation branch January 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants