Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-3042: set ADF download vars as adf_app role's arguments #1061

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Feb 11, 2025

@alxgomz alxgomz changed the title OPSEXP-3042: set ADF download vars as adf_ap role's arguments OPSEXP-3042: set ADF download vars as adf_app role's arguments Feb 12, 2025
@alxgomz alxgomz requested review from gionn and pmacius and removed request for gionn February 12, 2025 13:48
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove vars from 7.3 extra vars

.github/workflows/community.yml Show resolved Hide resolved
7.4.N-extra-vars.yml Outdated Show resolved Hide resolved
group_vars/all.yml Outdated Show resolved Hide resolved
vars/acs74.yml Outdated
Comment on lines 21 to 25
acc_artifact_id: alfresco-control-center
acc_repository: "{{ nexus_repository.releases }}"
acc_url: >-
{{ acc_repository }}/{{ acc_artifact_id }}/{{ acc_version }}/{{ acc_artifact_id }}-{{ acc_version }}.zip
acc_checksum: sha1:{{ acc_url }}.sha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid duplication lets have a vars/acs-post.yml (whatever) with those and include_var it after loading the first one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to playbook group var instead

@alxgomz alxgomz requested review from gionn and pmacius February 13, 2025 14:09
@alxgomz alxgomz requested review from gionn and pmacius February 13, 2025 16:00
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check tests because they are currently broken

@gionn gionn removed the request for review from pmacius February 14, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants