Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-3058 Move supported_os vars to version specific vars file #1057

Merged
merged 4 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/enteprise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ jobs:
matrix:
molecule_scenario:
- name: default
vars: vars-ubuntu20-73.yml
desc: EC2 ACS 7.3 (Ubuntu 20.04)
vars: vars-ubuntu22-73.yml
desc: EC2 ACS 7.3 (Ubuntu 22.04)
- name: default
vars: vars-rocky8.yml
desc: EC2 ACS 7.4 (Rocky Linux 8.9)
Expand Down
4 changes: 2 additions & 2 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"filename": "playbooks/acs.yml",
"hashed_secret": "3a0b8a438a9efa61267357269709a946d797b9bd",
"is_verified": false,
"line_number": 436,
"line_number": 447,
"is_secret": false
}
],
Expand Down Expand Up @@ -259,5 +259,5 @@
}
]
},
"generated_at": "2025-01-28T09:32:21Z"
"generated_at": "2025-02-10T14:15:39Z"
}
1 change: 1 addition & 0 deletions 7.3.N-extra-vars.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
acs_major_version: 73
acs:
artifact_name: alfresco-content-services-distribution
edition: Enterprise
Expand Down
1 change: 1 addition & 0 deletions 7.4.N-extra-vars.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
acs_major_version: 74
acs:
artifact_name: alfresco-content-services-distribution
edition: Enterprise
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ We expect distribution support to be added using mostly roles `vars` files. If
distro specific tasks are needed those should be skipped for other distros
and possibly added in separate task files.

New distributions must be added to the `supported_os` variable in the `group_vars/all.yml` file.
New distributions must be added to the `supported_os` variable in the `vars/acsXX.yml` files.

If a new OS enters the official supported matrix but is not supported by the
playbook. It must be mentioned in the [Versioning chapter of the
Expand Down
8 changes: 8 additions & 0 deletions docs/playbook-upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ title: Upgrading the playbook

## Unreleased version

### Handling of `supported_os` var

The `supported_os` variable is being moved into version-specific variable files
within the `vars/` directory. From this point forward, the `supported_os`
variable will more accurately reflect the supported OS matrix. However, we
reserve the right to specify newer distribution versions when testing
compatibility or evaluating support for minor releases.

### Search Enterprise is the new default search engine

The example inventories have been updated to default to Search Enterprise /
Expand Down
33 changes: 1 addition & 32 deletions group_vars/all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ nexus_repository:
{{ artifacts_repositories.enterprise.base_url }}/{{ artifacts_repositories.enterprise.repository }}/{{ artifacts_repositories.enterprise.group_id }}
development_releases: >-
{{ artifacts_repositories.enterprise.base_url }}/{{ artifacts_repositories.development.repository }}/{{ artifacts_repositories.enterprise.group_id }}
acs_major_version: 23
acs:
artifact_name: alfresco-content-services-distribution
edition: Enterprise
Expand Down Expand Up @@ -82,38 +83,6 @@ acc:
artifact_name: alfresco-control-center
repository: "{{ nexus_repository.releases }}"
version: 9.3.0
supported_os:
RedHat:
versions:
- 9.4
- 9.3
- 9.2
- 9.1
- 9.0
- 8.9
- 8.8
- 8.7
- 8.6
- 8.5
- 8.4
- 8.2
Rocky:
versions:
- 9.4
- 9.3
- 9.2
- 9.1
- 9.0
- 8.9
- 8.8
- 8.7
- 8.6
Ubuntu:
versions:
- 24.04
- 22.04
- 20.04
- 18.04
downloads:
acs_zip_url: >-
{{ acs.repository }}/{{ acs.artifact_name }}/{{ acs.version }}/{{ acs.artifact_name }}-{{ acs.version }}.zip
Expand Down
4 changes: 0 additions & 4 deletions molecule/default/vars-ubuntu20-73.yml

This file was deleted.

4 changes: 4 additions & 0 deletions molecule/default/vars-ubuntu22-73.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
MOLECULE_IT_IMAGE_ID: ami-032a56ad5e480189c # ubuntu/images/hvm-ssd/ubuntu-jammy-22.04-amd64-server-20250112
MOLECULE_IT_EXTRA_VARS: 7.3.N-extra-vars.yml
MOLECULE_IT_TEST_CONFIG: tests/test-config-7.3.json
MOLECULE_IT_PLATFORM: ubuntu22-73
11 changes: 11 additions & 0 deletions playbooks/acs.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
---
- name: Include vars based on acs major version
hosts: all
gather_facts: false
vars:
base_folder: "{{ playbook_dir }}/.."
vars_folder: "{{ base_folder }}/vars"
vars_file: "{{ vars_folder }}/acs{{ acs_major_version }}.yml"
tasks:
- name: Include vars based on acs major version
ansible.builtin.include_vars: "{{ vars_file }}"

- name: Check if current OS version is in the supported matrix
hosts: all:!external
gather_facts: true
Expand Down
19 changes: 19 additions & 0 deletions vars/acs23.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
supported_os:
RedHat:
versions:
- 9.5
- 9.4
- 9.3
- 8.10
- 8.9
Rocky:
versions:
- 9.5
- 9.4
- 9.3
- 8.10
- 8.9
Ubuntu:
versions:
- 22.04
- 24.04 # Testing for the upcoming 25.x acs version
10 changes: 10 additions & 0 deletions vars/acs73.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
supported_os:
RedHat:
versions:
- 8.10
- 8.9
- 8.8
- 8.7
Ubuntu:
versions:
- 22.04
18 changes: 18 additions & 0 deletions vars/acs74.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
supported_os:
RedHat:
versions:
- 8.10
- 8.9
- 8.8
- 8.7
- 8.6
Rocky:
versions:
- 8.10
- 8.9
- 8.8
- 8.7
- 8.6
Ubuntu:
versions:
- 22.04
Loading