Send group emoji #166
Open
Send group emoji #166
+1,389
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #78 and my own desire for such a feature, I added the ability to send the conversation emoji with the command of
/lor/like. It will default to the thumbs up emoji, as facebook does, if there is no group emoji set.This is working well on two of my mac computers, across various group and one-on-one chats. I was unable to get the tests running, so I didn't add a test for this. I saw another PR might have had a fix for the tests? I can add a proper test if that gets fixed.
I noticed a
package-lock.jsonwas added with my changes, I left it in there but I can remove it if you'd prefer.This is my first git hub/open source Pull Request, so if I mixed something up with the Pull Request process, please let me know. Thank you.