-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[English] Label improvement suggestions #300
Comments
@Mrnofish thanks for all of that! I will fix all. For geolocation, i agree, not sure what would be best |
@Mrnofish i think i looked at almost all of them except maybe the "improved clarity". Can you confirm? |
It's more consistent now. Uv, snowDepth, Dewpoint and Sealevel still employ non-standard forms. On pull-to-refresh I stand by my previous suggestion. For "show hourly chart.." the app is already using the word chart for that se two options, so I'm not sure I appreciate the meaning of your remark? The altenative you proposed doesn't sound very good to my ear either. Since I'm EASL too, maybe a native speaker such as @0-5-0 could chime in. For the new option "use odd background colors in hourly section" my suggestion would be more along the lines of "Alternate background colors in Hourly charts." |
Here's my input: Refresh:I'm not sure if you need to specify weather since I believe it does that by default anyways and since the setting is in the geolocation section, just focusing on the location seems fine... Fetch location when swipping down on main view. Main view if it only applies on the main view and not the daily view. I'd probably prefer swipping over pulling, avoiding find since users aren't necessarily searching for something specific so fetch seems more accurate or alternatively "Update location (or current location) when swipping down on main view". Chart:I think the issue with this one is that previously the app only had one hourly "graph", the default graph that came with the app, then eventually the hourly "chart" was added (the one that's also displayed under the 3 dots menu -> Chart). So there is some confusion between having 2 hourly "layouts" when looking at settings. It's not necessarily that selecting "Show hourly chart on daily or main view" disables the hourly chart, it just goes back to displaying the default hourly "graph". I fully agree that "Show alternate hourly layout" would be a good fit, I don't think it's necessary to mention full data fit. For the "Charts use full height in portrait" that applies to the 3 dots menu -> "Chart", and 3 dots menu -> "Compare models" I believe. Odd background:I agree Alternate or Alternating background colors in hourly chart" sounds better than "odd" background colors. To further clarify things maybe the "Show hourly chart" options from the "Charts" settings section should be moved to the new "Hourly" settings section. However some of those other settings like number of hours shown apply to both charts and the alternate hourly layout so it could be confusing. |
@Mrnofish @0-5-0 thanks a lot for both of you for your input. Your contribution to that app is quite amazing! I also went for I also indeed move most "charts" settings to hourly as they only apply to hourly charts. Awesome! |
I mistyped swipping, apparently it's "swiping" (one p), for the Geolocation option. Just looking at the Weather data settings "Uv Index" should be "UV Index" (with a capital V as well). The rest looks good :), thanks again! |
@Mrnofish ahah did not even check and simply copied ;) |
Just occurred to me there's a bunch more inside Compare Models:
I've used Title Case since the other items are spelled in the same way, however there are large parts of the app which use Sentence Case. Since I needed to look up the letter case variations, here's a Wikipedia explainer. |
The release from yesterday has fixed most of the Compare Model labels but at the top there's still: precipProbability, Wind_bearing and there seems to be 2 "Precipitation" entries. The rest look good. |
@0-5-0 thanks! last points fixed and will be in next release |
Under Preferences > Weather Data:
Some metrics use Proper Case (e.g. "Air Quality Index", "Sealevel Pressure"), while for most only the first letter is capitalized (e.g. "Beaufort wind scale").
"Uv Index" > "UV Index/index"
"snowDepth" > "Snow Depth/depth"
"Dewpoint" > "Dew Point/point"
"Sealevel pressure" >"Sea-level Pressure/pressure"
"UV index below won't be shown" > "UV Index won't be shown [if] below"
Under Preferences > Charts
For improved clarity, "Show hourly chart in [main|daily] view" could be changed to something like "Fit entire hourly chart in [main|daily] view" since the hourly chart is always displayed nevertheless.
Under Preferences > Units:
The "Unit" word is present is 4 out of 5 labels. Since the heading reads Custom Units and the menu is called Units, this seems superfluous.
Under Geolocation:
The text was updated successfully, but these errors were encountered: