Removing unnecessary additional storage initialization #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
requested changes
Jun 14, 2023
Comment on lines
-81
to
-83
| private ObjectFetcher fetcher; | ||
| private ObjectUploader uploader; | ||
| private ObjectDeleter deleter; |
There was a problem hiding this comment.
From our discussions, we explicitly wanted these to be separate, primarily to have separate S3 clients for different purposes.
There was a problem hiding this comment.
Should then this be documented? I vaguely remember that but it's not obvious
There was a problem hiding this comment.
Adjusting the PR accordingly
There was a problem hiding this comment.
However I still think that we then need to create separate clients inside s3 implementation instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.