Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use async lru_cache #1036

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: use async lru_cache #1036

merged 1 commit into from
Feb 4, 2025

Conversation

keejon
Copy link
Contributor

@keejon keejon commented Feb 3, 2025

lru_cache does not work with async functions

@keejon keejon force-pushed the keejon/fix-lru-cache branch 2 times, most recently from 7125695 to 8280596 Compare February 3, 2025 14:31
Copy link

github-actions bot commented Feb 3, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  serialization.py
Project Total  

This report was generated by python-coverage-comment-action

@keejon keejon marked this pull request as ready for review February 3, 2025 15:12
@keejon keejon requested a review from a team as a code owner February 3, 2025 15:12
@keejon keejon requested review from jjaakola-aiven and removed request for a team February 3, 2025 15:14
jjaakola-aiven
jjaakola-aiven previously approved these changes Feb 3, 2025
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keejon keejon force-pushed the keejon/fix-lru-cache branch from c49b198 to 480fee7 Compare February 3, 2025 22:59
@jjaakola-aiven jjaakola-aiven merged commit 74e8ea9 into main Feb 4, 2025
9 checks passed
@jjaakola-aiven jjaakola-aiven deleted the keejon/fix-lru-cache branch February 4, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants