Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of RetriableException #92

Open
1riatsila1 opened this issue Apr 12, 2022 · 1 comment
Open

Make use of RetriableException #92

1riatsila1 opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@1riatsila1
Copy link

1riatsila1 commented Apr 12, 2022

In order to make use of the kafka connector retrying mechanism, would it be possible to throw a RetriableException instead of a ConnectException here and here. This would enable us to make use of these configuration options.

The functionality that would be nice to have is that after the connector fails (after max.retries is exhausted) is that kafka automatically retries on set intervals to bring the connector back.

@jeqo
Copy link
Contributor

jeqo commented Jul 5, 2023

@1riatsila1 thanks and apologies for the belated response.

As I mentioned on #111, falling back to use RetriableException for error handling would require to refactor and break compatibility with the current error retry approach.
If the intention is to keep using the same retries and use connect retries as an additional safeguard, I found that rather hard to reason about. Users would have to change 2 separate exception handling approaches.

Connect retries would also eventually be exhausted as well, though I agree a backoff approach would be a better experience than the current fixed retries.
An alternative may be to implement the backoff strategy within the connector itself. wdyt?

@jeqo jeqo added the enhancement New feature or request label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants