Set timeout for requests #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksalj
requested changes
May 23, 2024
| @@ -2,6 +2,7 @@ | |||
| import threading | |||
| import requests | |||
|
|
|||
| TIMEOUT = 10 | |||
There was a problem hiding this comment.
@felixcheruiyot Why use 10 seconds as the default?
| @@ -81,7 +82,7 @@ def _init_service(self): | |||
|
|
|||
| @staticmethod | |||
| def __make_get_request(url, headers, data, params, callback=None): | |||
| res = requests.get(url=url, headers=headers, params=params, data=data) | |||
| res = requests.get(url=url, headers=headers, params=params, data=data, timeout=TIMEOUT) | |||
There was a problem hiding this comment.
@felixcheruiyot would it not be better to have the timeout value come all the way from the exposed methods? e.g.
....
sms.send("Hello Message!", ["+2547xxxxxx"], connectionOptions = { "timeoutSeconds": 10 })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to set timeout for requests.post and requests.get to avoid blocking other requests in case AT takes time to respond