Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hide_marker_traits pass doesn't update the FunSig.parent_params_info #482

Closed
sonmarcho opened this issue Dec 3, 2024 · 2 comments
Closed

The hide_marker_traits pass doesn't update the FunSig.parent_params_info #482

sonmarcho opened this issue Dec 3, 2024 · 2 comments
Labels
C-bug A bug in charon

Comments

@sonmarcho
Copy link
Member

The hide_marker_traits pass should update the number of parameters in FunSig.parent_params_info. This leads to bugs in Charon-ML when printing definitions, in particular here.

One side note: I'm not sure we actually want to keep the parents_param_info, and getting rid of it would solve the issue.
@sonmarcho sonmarcho added the C-bug A bug in charon label Dec 3, 2024
@Nadrieril
Copy link
Member

Nadrieril commented Dec 3, 2024 •
edited
Loading

I intend to remove parents_param_info as part of changing how we represent trait methods (#180). What do you use it for?

@sonmarcho
Copy link
Member Author

The use is deprecated : I'm actually going to get rid of it myself (I noticed other bugs to fix in Charon-ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug A bug in charon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nadrieril @sonmarcho