Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Module-Level Constants to Enums and Classes #1

Closed
ShearStress021 opened this issue Oct 12, 2024 · 10 comments
Closed

Refactor Module-Level Constants to Enums and Classes #1

ShearStress021 opened this issue Oct 12, 2024 · 10 comments
Assignees

Comments

@ShearStress021
Copy link

Screenshot 2024-10-12 151352

** The current codebase utilizes module-level constants for defining various settings, configurations, and related values. While this approach is straightforward, it can lead to issues with organization, readability, and type safety as the project grows. **

Copy link

Thank you for creating this issue! 🎉 @SUGAM-ARORA @Ojas-Arora will look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTE.md for guidelines on contributing to this project.

@Ojas-Arora
Copy link
Contributor

@ShearStress021 Tell the solution that you will provide for this.

@ShearStress021
Copy link
Author

i would cluster related constants together with either enum, class or namedtuples considering the relationship and datatype of the constants

@Ojas-Arora
Copy link
Contributor

@ShearStress021 Ok, Issue assigned to you.

@Ojas-Arora
Copy link
Contributor

@ShearStress021 What's the progress on this issue?

@ShearStress021
Copy link
Author

I’m going to work on the issue this weekend. I got a little busy over the past few days. can please also give the explanation on how to play the game.

@Ojas-Arora
Copy link
Contributor

@ShearStress021 U just neeed to run the main.py and make sure all the requirements libraries are installed.

@ShearStress021
Copy link
Author

the game is running but i think on the help icon instructions on how to play the game are needed

@Ojas-Arora
Copy link
Contributor

The given Instructions are sufficient to know how to play game if u have some more instructions that can be added u can add so.

Copy link

github-actions bot commented Nov 4, 2024

Hello @ShearStress021! 🎉

Your issue #1 - Refactor Module-Level Constants to Enums and Classes has been successfully closed.

We appreciate your valuable contribution and your help in improving the project. If you have any more ideas, questions, or issues, feel free to open a new issue or join the discussion in our community forum.

Stay awesome! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants