-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove stored card confirmation not responsive #3037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed animation after the removal fixes #3028
longyulongyu
requested review from
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
December 24, 2024 13:57
🦋 Changeset detectedLatest commit: 2a0145b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: 0 B Total Size: 769 kB ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
approved these changes
Jan 2, 2025
…button` font size to 14px
Quality Gate passedIssues Measures |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
max-height
as it overflows on smaller screen, causing bad visual effect.max-height
is removed, we need to rewrite how we do animation. Useddisplay: grid
together with transition ongrid-template-rows
instead.animation
tokens from BentoTested scenarios
Tested on device mode and real devices on BrowserStack.
Fixed issue: #3028