Toggle component #3031
Merged
Toggle component #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
|
|
Size Change: 0 B Total Size: 769 kB ℹ️ View Unchanged
|
size-limit report 📦
|
m1aw
reviewed
Dec 18, 2024
| disabled={disabled} | ||
| checked={checked} | ||
| onChange={onInputChange} | ||
| aria-label={computedAriaLabel} |
There was a problem hiding this comment.
We don't need aria-label here. The value from the label already comes from the wrapping label.
There was a problem hiding this comment.
I followed the Bento implementation, and they do support having it without a label - that is why we have this property and that the 'label' property is not mandatory.
There was a problem hiding this comment.
What is the use case of having a toggle without any label?
There was a problem hiding this comment.
To be honest I am not sure - The bento definition for Toggle says that 'toggle only' is one of the possible ways of using it, although I don't see any use-case (at least for us) right now.
I added that anyway since I wanted to make the component comply with the Bento one.
But if you think that we don't need this, then I can remove this feature
m1aw
approved these changes
Dec 18, 2024
longyulongyu
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
togglecss variables from Bento to properly provide the correct colors/values to the Toggle SCSS file(This component will be used in the fastlane branch)
Tested scenarios