Add e2e tests for kcpAuthentication, stored-card-amex, stored-card-mc and stored-card-visa #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
|
|
Size Change: 0 B Total Size: 768 kB ℹ️ View Unchanged
|
size-limit report 📦
|
|
sponglord
reviewed
Dec 20, 2024
| await cardWithKCP.fillExpiryDate(TEST_DATE_VALUE); | ||
| await cardWithKCP.isPayable(); | ||
| await cardWithKCP.pay(); | ||
| await expect(cardWithKCP.paymentResult).toContainText(PAYMENT_RESULT.authorised); |
There was a problem hiding this comment.
Does this whole file not overlap with e2e/card/kcp/card.kcp.spec.ts?
There was a problem hiding this comment.
I am not 100% sure because there is a paymentSuccessfulMock in the e2e/card/kcp/card.kcp.spec.ts file i suppose it's not really making a payment call.
I think if we remove the paymentSuccessfulMock those 2 files are overlapping.
There was a problem hiding this comment.
Yeah, I think, at the time, we weren't sure if we had an actual, working korean local card number - so I guess that's why @ribeiroguilherme used a mock?
There was a problem hiding this comment.
I remember that testing korean card was flaky - initially it was failing all the time; then it started to work somehow; then from time to time we were getting a redirect to a weird page asking to inform birthdate and 2 digits pin, which causes the current kcp test to fail
sponglord
approved these changes
Dec 20, 2024
sponglord
reviewed
Dec 20, 2024
| @@ -14,6 +14,10 @@ export abstract class Base { | |||
| await this.isComponentVisible(); | |||
| } | |||
|
|
|||
| async isPayable() { | |||
There was a problem hiding this comment.
We have several places where we either say:
await page.waitForFunction(() => globalThis.component.isValid === true);
or
await page.waitForFunction(() => globalThis.component.isValid === false);
This function could take a parameter & then be used in all these places
There was a problem hiding this comment.
Yes it's a nice find. I'll refactor this in another PR 😄.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary